Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fixes providesTemporaryUrls on AwsS3V3Adapter #44009

Merged
merged 4 commits into from
Sep 5, 2022

Conversation

pyrou
Copy link
Contributor

@pyrou pyrou commented Sep 5, 2022

When using providesTemporaryUrls introduced in #43317 on a s3 disk, providesTemporaryUrls() method always returns false

>>> Storage::disk('s3')->providesTemporaryUrls()
=> false // expected true

This is because providesTemporaryUrls implementation relies on adapter getTemporaryUrl method existence which doesn't exists on League\Flysystem\AwsS3V3\AwsS3V3Adapter

Since Illuminate\Filesystem\AwsS3V3Adapter overrides temporaryUrl, and doesn't rely on adapter, we can also safely override providesTemporaryUrls method to always return true.

@taylorotwell taylorotwell merged commit 5de463e into laravel:9.x Sep 5, 2022
@pyrou pyrou deleted the patch-1 branch September 6, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants