[9.x] Fixes providesTemporaryUrls on AwsS3V3Adapter #44009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using providesTemporaryUrls introduced in #43317 on a
s3
disk, providesTemporaryUrls() method always returns falseThis is because providesTemporaryUrls implementation relies on adapter getTemporaryUrl method existence which doesn't exists on
League\Flysystem\AwsS3V3\AwsS3V3Adapter
Since
Illuminate\Filesystem\AwsS3V3Adapter
overridestemporaryUrl
, and doesn't rely on adapter, we can also safely override providesTemporaryUrls method to always return true.