Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Remove hard coded Menlo font from dd source file function output #44331

Merged
merged 1 commit into from
Sep 28, 2022
Merged

[9.x] Remove hard coded Menlo font from dd source file function output #44331

merged 1 commit into from
Sep 28, 2022

Conversation

aneeskhan47
Copy link
Contributor

@aneeskhan47 aneeskhan47 commented Sep 27, 2022

Hi,

The PR was made by awesome @nunomaduro #44211. There was a hardcoded 'font-family: Menlo' which not everyone has except apple macOS users. I think browser should auto fallback to system font 😄

I'm on windows so I don't have this font installed I see this:

2022-09-27_23-24

It should be like this:

2022-09-27_23-25

@aneeskhan47 aneeskhan47 changed the title [9.x] Removed hard coded Menlo font from dd source file function output [9.x] Remove hard coded Menlo font from dd source file function output Sep 27, 2022
@taylorotwell taylorotwell merged commit abd4787 into laravel:9.x Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants