New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Only prints source on `dd` calls from `dump.php` #44367

Merged

taylorotwell merged 1 commit into 9.x from fix/source-when-not-called-from-dump

Sep 29, 2022

Member

nunomaduro commented Sep 29, 2022 •

edited

Loading

This pull request solves 2 things:

Removes the DEBUG_BACKTRACE_PROVIDE_OBJECT flag from debug_backtrace making the call to that function more performant.
Removes hardcoded 7 key from trace, and guesses the trace key dynamically - as the trace may change as described on the 44366 issue. By guessing the key dynamically, we only try to guess the source on the there is direct call to the dd or dump global functions.


          Only prints source on dd calls from dump.php

d98a46d

nunomaduro requested a review from taylorotwell

September 29, 2022 09:50

nunomaduro self-assigned this

nunomaduro added the bug label

taylorotwell merged commit 71f2154 into 9.x

taylorotwell deleted the fix/source-when-not-called-from-dump branch

September 29, 2022 13:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug