-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Prevents booting providers when running env:decrypt
#44654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joedixon
force-pushed
the
fix/env-decrypt
branch
from
October 19, 2022 14:00
354e8dd
to
65e2cc4
Compare
joedixon
force-pushed
the
fix/env-decrypt
branch
from
October 19, 2022 15:03
e9d97c7
to
24a685f
Compare
joedixon
force-pushed
the
fix/env-decrypt
branch
from
October 19, 2022 15:11
24a685f
to
19781c9
Compare
Any reason you didn't opt-in for making the BroadcastServiceProvider a deferred provider? |
There are a couple of reasons for that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the
env:decrypt
command which can occur when a service provider relies on the presence of a value in the environment file.For example, the Pusher broadcast driver relies on the API token set in the environment and that token doesn't exist until the environment file is decrypted. However, when running the command, the
BroadcastServiceProvider
is booted which attempts to instantiate Pusher and an exception is thrown.This PR aims to resolve that issue by omitting
\Illuminate\Foundation\Bootstrap\BootProviders::class
from the kernel bootstrappers only when invoking theenv:decrypt
command.This functionality has been added to both the
handle
andcall
methods.As part of this, I have also added the option to decrypt a file to a different path.
Running the command above would result decrypting a file called
.env.encrypted
to/tmp/.env
Of course, you may combine this with the other options:
The above command will decrypt
.env.production.encrypted
to/tmp/.env