Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Allow route group method to be chained #44825

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

ockle
Copy link
Contributor

@ockle ockle commented Nov 2, 2022

This allows the group method to be chain called when defining routing. An example of where this would be useful:

// In RouteServiceProvider
Route::middleware('web')
    ->domain('foo.example.com')
    ->group(base_path('routes/common.php')
    ->group(base_path('routes/foo.php');

Route::middleware('web')
    ->domain('bar.example.com')
    ->group(base_path('routes/common.php')
    ->group(base_path('routes/bar.php');

@ockle ockle changed the title Allow route group method to be chained [9.x] Allow route group method to be chained Nov 2, 2022
@PerryvanderMeer
Copy link
Contributor

@ockle dockblocks should be updated too 🚀

@ockle
Copy link
Contributor Author

ockle commented Nov 3, 2022

@PerryvanderMeer Updated, thanks 👍

@taylorotwell taylorotwell merged commit c76c3bd into laravel:9.x Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants