Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Improved error logging for unmatched routes and route not found #45206

Merged
merged 4 commits into from
Dec 7, 2022
Merged

[9.x] Improved error logging for unmatched routes and route not found #45206

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42c7a1b
Improved error logging for unmatched routes and route not found
Dec 6, 2022
54f1b65
Update AbstractRouteCollection.php
Dec 6, 2022
aeb2ee0
Update AbstractRouteCollection.php
Dec 6, 2022
634c146
Update AbstractRouteCollection.php
Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/Illuminate/Routing/AbstractRouteCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ protected function handleMatchedRoute(Request $request, $route)
return $this->getRouteForMethods($request, $others);
}

throw new NotFoundHttpException;
throw new NotFoundHttpException(sprintf(
'The route %s could not be found.',
$request->path()
));
}

/**
Expand Down Expand Up @@ -101,7 +104,30 @@ protected function getRouteForMethods($request, array $methods)
}))->bind($request);
}

$this->methodNotAllowed($methods, $request->method());
$this->requestMethodNotAllowed($request, $methods, $request->method());
}

/**
* Throw a method not allowed HTTP exception.
*
* @param \Illuminate\Http\Request $request
* @param array $others
* @param string $method
* @return void
*
* @throws \Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException
*/
protected function requestMethodNotAllowed($request, array $others, $method)
{
throw new MethodNotAllowedHttpException(
$others,
sprintf(
'The %s method is not supported for route %s. Supported methods: %s.',
$request->path(),
$method,
implode(', ', $others)
)
);
}

/**
Expand All @@ -110,6 +136,7 @@ protected function getRouteForMethods($request, array $methods)
* @param array $others
* @param string $method
* @return void
* @deprecated use requestMethodNotAllowed
*
* @throws \Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException
*/
Expand Down