[10.x] Fix RateLimiter callback return substitution (#44820) #45611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaking update allows users to control return values explicitly without converting to boolean and fixes the substitution of false with true.
Bug description:
The
RateLimiter::attempt
method contains?:
operator and casts the return value of$callback
function totrue
for all list of values considered as false.Steps To Reproduce:
Case: 3rd-party APIs may return empty arrays as a successful response.
Brings backward incompatibility to those who depend on
true
return.