[9.x] Fixes blade escaped tags issue #45928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #45915
In the added test there are 4 matches, in the second replacement
@@endforeach
with@endforeach
in the second replacement.Then the final replacement searches for
@endforeach
to replace it with the compiled version, but it finds what was produced by the previously escaped tag because it starts the search from the beginning of the string.Solution:
Logically when replacing the matches found by REGEX one after the other using
Str::replaceFirst
, we have to continue from where we last left off.