[10.x] Fix route:cache from excluding octane routes #46448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmastech
reviewed
Mar 13, 2023
added 2 commits
March 13, 2023 11:37
CharlesBilbo
changed the title
CharlesBilbo
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
cosmastech
reviewed
Mar 15, 2023
|
Octane::route is not really a documented stable feature of Octane at the current moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running route:cache command with octane routes they are being excluded from the cached routes file. This causes octane routes to 404 when cached.
While caching the routes gives a negative performance to swoole (not sure about road runner) by increasing the amount of memory needed for each request this will at least prevent them prevent them from 404ing.
This will also prevent questions like this
laravel/octane#596
laravel/octane#658
This PR is a required dependency for this PR.
laravel/octane#659
Additonally it doesnt seem like Octane::route method doesn't work with road runner.