[10.x] Convert eloquent builder to base builder in whereExists #46460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
whereExists
method accepts an Eloquent builder (see docblock on whereExists-methods) but theaddWhereExistsQuery
method used bywhereExists
only accepts a base builder. To fix that I added code that converts Eloquent builder to base builder before calling theaddWhereExistsQuery
method.(The other solution would be changing the parameter type on the
addWhereExistsQuery
method, but I thought converting the type in thewhereExists
method would probably be the preferred way of handling this)