[9.x] Fix Job delay property when dispatched through facade + data_get()
closure fix
#46582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #46568 and an improvement for #46505.
This also includes a helpful improvement for the
data_get()
global helper, since for PHP 8.0, trying to access properties on a closure (closures are stillis_object()
) will cause it to error. This PR makes it so that when you now calldata_get($closure, 'someProperty')
, it will return null (or some other default).Sadly I couldn't make any tests for the
enqueueUsing
method to test the correct$delay
property, since the method calls a closure further on within the function which is different for each and every Queue driver.