[10.x] Fix query builder whereBetween method with carbon date period

[tegos]

Fixes issue when using query builder method whereBetween with param of custom carbon date period.

$from = '01.03.2023';
$to = '31.03.2023';

$period = CarbonPeriod::create($from, $to);

$orders = Order::query()->whereBetween('created_at', $period)->get();

// the query will be
// select * from `orders` where `created_at` between '2023-03-01 00:00:00' and '2023-03-02 00:00:00'
// instead select * from `orders` where `created_at` between '2023-03-01 00:00:00' and '2023-03-31 00:00:00'

[bert-w]

What's happening here? I dont understand the code comment above.

[Rizky92]

What's happening here? I dont understand the code comment above.

CarbonPeriod generates list of dates on daily interval when converted into array. So instead of grabbing first and last date, it grabs the first and next date on the array.

[tegos]

Hello, @bert-w. Don't worry, mate.

In the query builder, method whereBetween accept second parameter iterable $values, which can be a CarbonPeriod instance.

But when use CarbonPeriod parameter the method don't work properly, it take only first date and next date insted last date of period.

See example

$from = Carbon::now()->startOfYear(); // 2023-01-01
$to = Carbon::now()->endOfYear(); // 2023-12-31

$period = CarbonPeriod::create($from, $to);

$orders = Order::query()->whereBetween('created_at', $period)->get();

#result query
select * from `orders` where `created_at` between '2023-01-01 00:00:00' and '2023-01-02 00:00:00'

'2023-01-01 00:00:00' and '2023-01-02 00:00:00'