[10.x] Added parameters to timezone validation rule #47171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem that I've got
IANA has officially changed the Ukraine's timezone from Ukraine/Kiev to Ukraine/Kyiv in 2022b version of tzdata. But some systems still use the old versions of tzdata. And timezone validations are started to fail.
Ways to resolve
To resolve that problem in my project I've created custom validation rule for timezones that is actually a copy of current timezone validation but with a parameter DateTimeZone::ALL_WITH_BC that returns all timezones list with a Backward Compatibility. So all old timezone names will be accepted with this parameter.
What I have changed in the PR
I have modified current timezone validation to accept parameters that could be passed to timezone_identifiers_list method. It could be useful also for those projects that are designed to work only in specific country. So developers can accept the timezones from the only country.