[10.x] Fix typehint for EventServiceProvider::$observers
property
#47316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
New typehint was added d800f9e which is too strict (only supports array of strings).
My syntax is valid (unless string-to-string mapping is now deprecated in which case whoops I missed the memo). AFAICT it's still valid in
HasEvents
:Also, while you can't instantiate objects directly in the property declaration, it's still important to define a typehint that supports objects, otherwise the following valid logic would appear invalid in static analysis:
I mean, I never use objects in this context, but it's technically valid so it should be typehinted as valid too.