[10.x] Fix mapped renderable exception handling #47347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR #47201, I tries to fix the handling of mapped exceptions with a
render
hook. The PR was reverted due to a significant mistake I made by moving themapException
method together withprepareException
, which I should not have touched. As it was reported by RobertBoes that change breaks exception rendering on the extended internal exceptions. I sincerely apologize for that.In this PR I have fixed issue from #47201 and also added a missing test for renderable exceptions.
Let me describe the progrem again. When we have a custom exception that defines
report
andrender
hooks, only thereport
hook works while therender
hook is never called. For instance:With this change both methods
report
andrender
will map the exception at the beginning and handle it correctly: