Fix Cache::many() with small numeric keys #48423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache::many([1,2,3])
for an empty cache returns[1 => 2, 2 => 3, 3 => null]
instead of[1 => null, 2 => null, 3 => null]
.String keys like this \Cache::many(['1','2','3']) make no difference.
The issue is that
Illuminate\Cache\Repository
tries to set default values for missing keys, and in case of small numeric keys it treats those as positions: e.g. when$keys = [1, 2, 3]
the value of$keys[1]
is2
.This code in this PR tests if
$keys
is not an associative array (in other words, it doesn't contain the defaults, just the keys) and if so, just returnsnull
for missed cache keys.