Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Add Windows fallback for multisearch prompt #48565

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Sep 27, 2023

This PR adds a Windows fallback for the new multisearch prompt.

Similarly to the search prompt, there is no direct Symfony equivalent, so the fallback must first prompt the user for their search query and then prompt them to select from the matching results.

Symfony's choice prompt requires you to select an option but the multisearch does not. To work around this, we inject a "None" option at the top of the list, which is selected by default. If that option is selected, then we filter it from the returned array.

@taylorotwell taylorotwell merged commit f402d3f into 10.x Sep 27, 2023
20 checks passed
@taylorotwell taylorotwell deleted the multisearch-fallback branch September 27, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants