Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Moves logger instance creation to a protected method #48759

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[10.x] Moves logger instance creation to a protected method #48759

merged 2 commits into from
Oct 18, 2023

Conversation

rodrigopedra
Copy link
Contributor

This PR:

  • Adds a new protected method to the Illuminate\Foundation\Exceptions\Handler class: makeLogger()
    • This method allows user-land code to easily override the LoggerInterface instance used to report an exception
    • One scenario is when exceptions should be reported to a channel different from the other logging activities within a project
  • No tests were added, as it is just a simple method extraction

@taylorotwell taylorotwell merged commit 2dcc960 into laravel:10.x Oct 18, 2023
20 checks passed
timacdonald pushed a commit to timacdonald/framework that referenced this pull request Oct 24, 2023
…48759)

* moves logger instance creation to a protected method

* formatting

---------

Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants