Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Fix replaceMatches in Str class #48760

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[10.x] Fix replaceMatches in Str class #48760

merged 1 commit into from
Oct 18, 2023

Conversation

hosmelq
Copy link
Contributor

@hosmelq hosmelq commented Oct 18, 2023

This pull request resolves the previous issue with PR #48727, where the 'static' keyword was missing. I forgot to include it.

@hosmelq
Copy link
Contributor Author

hosmelq commented Oct 18, 2023

cc: @driesvints @taylorotwell

mpyw
mpyw reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@mpyw mpyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylorotwell taylorotwell merged commit 8d8d5f7 into laravel:10.x Oct 18, 2023
21 checks passed
timacdonald pushed a commit to timacdonald/framework that referenced this pull request Oct 24, 2023
@hosmelq @timacdonald
add missing static keyword (laravel#48760)
ba10842
@hosmelq hosmelq deleted the fix-replace-matches-in-str-class branch October 29, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpyw mpyw mpyw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hosmelq @mpyw @taylorotwell