[10.x] Make inherited relations and virtual attributes appear in model:show command #48800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
jessarcher
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Thanks @sebj54!
I've tested it locally, and it works great!
Performance is part of why we want to ignore methods on the Model class, but it's mostly because there are methods on the Model class that call other relationship methods (e.g. morphedByMany calls morphToMany), which would trigger a false positive.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48798
I did not find any existing test related to this feature. Feel free to tell me if I missed anything, because it's my first PR to the framework