[11.x] Support eager loading with limit #49695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests aren't related to this PR. |
|
@staudenmeir Massive work 💪 Hope your other packages will have Laravel team attention. |
| */ | ||
| public function useLegacyGroupLimit(Builder $query) | ||
| { | ||
| $version = $query->getConnection()->getReadPdo()->getAttribute(PDO::ATTR_SERVER_VERSION); |
There was a problem hiding this comment.
Suggested change
| $version = $query->getConnection()->getReadPdo()->getAttribute(PDO::ATTR_SERVER_VERSION); | |
| $version = $query->getConnection()->getServerVersion(); |
There was a problem hiding this comment.
Could you maybe send in a follow up PR with your suggestions? Thanks!
| */ | ||
| protected function compileGroupLimit(Builder $query) | ||
| { | ||
| $version = $query->getConnection()->getReadPdo()->getAttribute(PDO::ATTR_SERVER_VERSION); |
There was a problem hiding this comment.
Suggested change
| $version = $query->getConnection()->getReadPdo()->getAttribute(PDO::ATTR_SERVER_VERSION); | |
| $version = $query->getConnection()->getServerVersion(); |
|
Thanks @staudenmeir! 🥳 |
This was referenced Jan 16, 2024
|
Great work!!! |
|
Thank a lot <3 |
|
can't wait for your other eloquent extension packages to be included in the core. |
|
Thank you. |
|
Thanks a lot <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed: A new version of #26035 that integrates the eloquent-eager-limit package.
Support for MySQL 5.7
According to the current docs, Laravel 11 won't support MySQL 5.7 anymore. I still included the legacy workaround for MySQL 5.7 since the necessary code already exists and MySQL 5.7 is still being tested. The MySQL support in Laravel 11 is also still being discussed.