Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix getPrefix behaviour for cached routes #51542

Closed
wants to merge 3 commits into from
Closed

[11.x] Fix getPrefix behaviour for cached routes #51542

wants to merge 3 commits into from

Conversation

mohammadMghi
Copy link

I solved bug : #50239

@rodrigopedra
Copy link
Contributor

Suggestions:

  1. Give a description of what the PR solves
    • Just linking to an issue usually gets your PR closed with a request to open a new one with a proper description
  2. Add a test case to ensure cached and non-cached routes behave the same
    • I don't know enough about the matter to give you suggestions on how to test it

@driesvints driesvints changed the title 50239 Fix getPrefix behaviour for cached routes May 23, 2024
@driesvints driesvints changed the title Fix getPrefix behaviour for cached routes [11.x] Fix getPrefix behaviour for cached routes May 23, 2024
@taylorotwell
Copy link
Member

No tests so no idea if anything is solved.

@mohammadMghi
Copy link
Author

@taylorotwell Now i'm trying to writing test , please wait , i open new pull request with details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadMghi @rodrigopedra @taylorotwell