Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update facade dockblocks #52750

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Update facade dockblocks #52750

merged 1 commit into from
Sep 12, 2024

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Sep 12, 2024

Adds auto-generated docblocks for:

  • Concurrency
  • Exceptions
  • Schedule

Additional fixes from the latest documenter improvements...

  • Removes a duplicated Macroable::macro method param (general)
  • Fixes Cache::flexible parameter types where array shapes are used (general)
  • Fixes Handler::level parameter type where constants are used (specific)
  • Fixes Route::tap return type where conditional return types are used (general)

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@timacdonald timacdonald marked this pull request as ready for review September 12, 2024 01:47
@timacdonald timacdonald changed the title Update facade documenter Update facade dockblocks Sep 12, 2024
Comment on lines 37 to 39
* @see \Illuminate\Foundation\Exceptions\Handler
* @see \Illuminate\Contracts\Debug\ExceptionHandler
* @see \Illuminate\Support\Testing\Fakes\ExceptionHandlerFake
*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need the contract here. The handler already implements the contract.

@taylorotwell taylorotwell merged commit 09bc55a into laravel:11.x Sep 12, 2024
33 checks passed
@timacdonald timacdonald deleted the facade branch October 3, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants