Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix exception renderer to display correct view file and error line #53418

Draft
wants to merge 4 commits into
base: 11.x
Choose a base branch
from
Draft

[11.x] Fix exception renderer to display correct view file and error line #53418

wants to merge 4 commits into from
+29 −5

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Nov 6, 2024 •
edited
Loading

Before

CleanShot 2024-11-06 at 10 52 23

After

CleanShot 2024-11-06 at 10 47 23

crynobone and others added 4 commits November 6, 2024 10:45
@crynobone
[11.x] Fix exception renderer to display correct view file and error …
7595dc8 
…line

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone
wip
b21c0ae 
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@taylorotwell
Update Frame.php
860c122
@taylorotwell
Update Frame.php
c62f005
@taylorotwell
Copy link
Member

Merging this and just dropping an undefined variable like {{ $something }} into welcome.blade.php gives an incorrect error report.

@taylorotwell taylorotwell marked this pull request as draft November 11, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crynobone @taylorotwell