[11.x] Introduce TFetchMode generic to support for different PDO fetch modes
#53477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayw-geek
changed the title
TFetchMode generic to support for different PDO fetch modesTFetchMode generic to support for different PDO fetch modes
…t PDO fetch modes in Query Builder
kayw-geek
force-pushed
the
bugfix/fix-incorrect-generic-param-passing-for-build
branch
from
8489f31 to
5b34eac
Compare
|
No plans to mess with this atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR introduces the
TFetchModegeneric to improve PHPDoc annotations in the Query Builder, ensuring better clarity and support for various PDO fetch modes.Reason:
The current default fetch mode in
ConnectionisPDO::FETCH_OBJ. When a custom Connection is used, the Query Builder's PHPDoc does not reflect the correct fetch mode, leading to potential issues in type hinting and IDE support.