Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates docblock for duplicates collection method to correct its return type #53499

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

gms8994
Copy link
Contributor

@gms8994 gms8994 commented Nov 13, 2024

The return type that is hinted by duplicates suggests that the callable should return bool, but the callable is passed directly to map, which is typehinted as returning a TMapValue.

Additionally, the documentation online shows no example use of calling duplicates with a callable, which will be my next stop.

@taylorotwell taylorotwell merged commit 448b1b5 into laravel:11.x Nov 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants