[10.x] Backport 11.x PHP 8.4 fix for str_getcsv deprecation #54074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Jan 3, 2025
|
I think the previous PR that includes changes that are specifically for allowing 10.x to run on PHP 8.4 causes confusion then. If it's not going to be supported then why introduce any changes to support it? |
|
Oh, hmmm. The compatibility is only partial. CI does not test on 8.4. Laravel 11 is the first version to officially support PHP 8.4. In any case, like you say, this is not a security fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that 10.x is technically in security fix mode only, but with the PHP 8.4 compat pr (#53612), a large amount of fixes were made to bring some form of PHP 8.4 support to 10.x.
The change included in this PR has already been implemented in 11.x in PR #53571.
Considering this usage of
str_getcsvis within the Validation rules parser, it can get hit a significant amount of times and cause flooding to reporting systems (ex: Sentry).