[12.x] Refactor: use orderByDesc()
#57353
Open
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How long until @browner12 sends a PR reverting your changes (see #53563)? |
|
I didn’t get it. Why would they revert it? |
|
yah, don't do this. you growing the call stack and introducing a (minor) performance hit for no gain. |
|
Makes sense. But then why is this method in the source code? |
|
Because not everybody is a performance purist to the extent, browner is. And Laravel has a long history as a framework of offering convenience functions and methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all instances of
$this->orderBy(..., 'desc')to use the more expressive$this->orderByDesc(...)method from query builder.