[12.x] Refactor unreleased data_has helper #57580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #57570 introduced the
data_has()helper to aid fixing theEnumerateValues::value()implementation.The new helper works for the purposes of that PR, but is misaligned with other sibilings helpers, such as
data_get().For example, using the current implementation, all these assertions fail when then should pass:
This assertions were adapted from the
data_get()helper tests.The last one fails due to the current implementation using a while loop to search for a property segment existence.
This PR:
data_has()helper to behave more aligned with other sibling helpers.data_get()helper\data_has()usesproperty_exists()anddata_get()usesisset()to verify a object's propertydata_has()helper with assertions that would fail with the current implementation