Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Yarn #1847

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Drop Yarn #1847

merged 1 commit into from
Jan 27, 2023

Conversation

browner12
Copy link
Contributor

I know Yarn was a good stop-gap years ago for when there were serious shortcomings with NPM, but now that NPM has gotten its act together, I think we can drop Yarn support.

Yarn users are welcome to add this into their own custom aliases, but I think we're covering the 99% use case here.

@svpernova09
Copy link
Contributor

Thanks!

@svpernova09 svpernova09 merged commit 15263f5 into laravel:main Jan 27, 2023
@ankurk91
Copy link

bower must be removed as well.

@svpernova09
Copy link
Contributor

Just because we're dropping the installs in Homestead does not mean we drop them in Settler. This way if you still need Yarn, it'll be in the base box install.

@browner12
Copy link
Contributor Author

Joe, I'm a little confused here I guess. Were these scripts doing anything, then, if it was already in the base box?

@browner12 browner12 deleted the drop-yarn branch January 27, 2023 05:15
@svpernova09
Copy link
Contributor

resources/aliases is where we store the default aliases for Homestead. By removing the Yarn aliases they won't work out of the box anymore, but the Yarn binary will still be in the base box, so if users need Yarn, it's still there for them.

The bin/wsl-init script is to build a settler/homestead-like environment for Windows Subsystem for Linux, it's outdated and needs to be updated w/ the latest Settler changes.

@browner12
Copy link
Contributor Author

Gotcha, thanks! Yah, the WSL script was the one throwing me off. I've sent in another PR for that.

@browner12 browner12 mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants