Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL support is added to Apache virtual hosts #419

Merged
merged 3 commits into from
Jan 5, 2017
Merged

SSL support is added to Apache virtual hosts #419

merged 3 commits into from
Jan 5, 2017

Conversation

umutkirgoz
Copy link
Contributor

SSL support is added to Apache virtual hosts

Umut KIRGÖZ and others added 2 commits January 5, 2017 13:53
@svpernova09 svpernova09 self-assigned this Jan 5, 2017
@taylorotwell
Copy link
Member

I'm not sure we should even be supporting Apache. I know nothing about it and it's not supported on Forge or Valet.

@svpernova09 svpernova09 reopened this Jan 5, 2017
@svpernova09 svpernova09 merged commit 7cff030 into laravel:master Jan 5, 2017
@svpernova09
Copy link
Contributor

@umutkirgoz Thanks for the PR! I also realized that Apache was totally broken and I'm surprised it was working at all for you. Apache is fixed and working again. This will probably be the last update we'll see on Apache since Forge doesn't support it, (as Taylor mentioned). Homestead will likely stop supporting it sometime in the future.

@browner12
Copy link
Contributor

as much as I wish I could do everything on nginx, I work on some projects that require apache (more specifically require their htaccess file) to work. While I am pushing towards refactoring these sites to be web server agnostic, it is a slow process.

it is really nice to have Apache available on Homestead, so I can switch over quickly for the projects that require it. I would vote to not remove it as long as it's not hurting anything.

I try and be an advocate for Laravel and all its great tools whenever I can, and having support for things like apache, in addition to the preferred and suggested software, helps smooth the transition for people reluctant to change.

my 2c. thanks.

@umutkirgoz
Copy link
Contributor Author

We are using Laravel and its homestead dev environment when building the future of Mynet (Biggest portal of Turkey with ~1 billion pageviews per month)

I plan to build a homestead fork with multiple web server support (or maybe default nginx, and optional apache)

This was the first step of fixing the provisioning problem of Apache virtual hosts. Vagrant box needs to be customized...

tHanks for interest...

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants