Use native Ruby function to determine home directory #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on Windows 10 & MacOS Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running "vagrant up" on native Windows shell will result an error because the Windows shell does not use the ~ as an reference to the home directory. Ruby actually offers a Dir.home method that handles this issue in different platforms. It basically uses the %HOMEDRIVE% and %HOMEPATH% variables on Windows and the ~ on *nix platforms. So this would at least fix the issue with Windows users not needing to run Git bash or cygwin.
http://ruby-doc.org/core-2.0.0/Dir.html#method-c-home