use callAfterResolving to register QueueManager #1089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the nature of how our app/monolith is registering service providers (we disabled autodiscovery), the resolving listener would never trigger because of another error tracking dependency.
While serving the app via the console,
HorizonServiceProvider
is always registered. But when serving over HTTP, it is only registered lazily via some domain\context inference in a global middleware. At that point however, the error tracking package has already resolved theQueueManager
instance causing the app to crash when trying to visit the Horizon dashboard.Using
callAfterResolving
would fix our issue and not break anything for any other user, as it just adds an extra if-check under the hood.Thank you!