Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Upgrade from Vue 2 to Vue 3 #1496

Merged
merged 10 commits into from
Sep 11, 2024
Merged

[5.x] Upgrade from Vue 2 to Vue 3 #1496

merged 10 commits into from
Sep 11, 2024

Conversation

osbre
Copy link
Contributor

@osbre osbre commented Sep 11, 2024

Vue 2 has reached EOL. I think it's a good idea to migrate to Vue 3 since there are only a few changes to make it happen:

  1. Update dependencies and Vue initialization in app.js.
  2. Remove redundant/unused addTagModalClosed event dispatching due to the event bus being deprecated and the event itself being unused by Horizon.
  3. Reorganize the routes as nested so they still highlight as active in the sidebar due to the change in vue-router v4 active link logic.

I have tested the app and it works perfectly fine as before. Vue 3 💚

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@osbre osbre marked this pull request as ready for review September 11, 2024 12:04
@taylorotwell taylorotwell merged commit 267975e into laravel:5.x Sep 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants