Search by tags in pending and completed jobs #1513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced listeners to handle job tags for pending and completed jobs, and updated controllers to support tag-based filtering of jobs. Added tests to verify the functionality of these new features.
Added a condition to hide the search bar when viewing silenced jobs in the recent jobs component. This change ensures the UI remains uncluttered and contextually relevant based on the job type displayed.
Standardize formatting by adjusting whitespace and quotation styles across multiple files. This includes adding spaces in conditional statements, aligning parameter annotations, and ensuring consistent object literals formatting in test cases.
Standardize formatting by adjusting whitespace and quotation styles across multiple files. This includes adding spaces in conditional statements, aligning parameter annotations, and ensuring consistent object literals formatting in test cases.
Standardize formatting by adjusting whitespace and quotation styles across multiple files. This includes adding spaces in conditional statements, aligning parameter annotations, and ensuring consistent object literals formatting in test cases.
Standardize formatting by adjusting whitespace and quotation styles across multiple files. This includes adding spaces in conditional statements, aligning parameter annotations, and ensuring consistent object literals formatting in test cases.
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
|
@taylorotwell unfortunately, if I had a Lambo, I wouldn't have the time or priority for it either... just kidding 👿😛. I have created a package for this functionality: https://github.com/mvd81/laravel-horizon-tag-search-in-pending-and-completed-jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce functionality for searching tags within pending and completed jobs, aligning with the existing functionality for failed jobs.
Screencast
screencastPRHorizon.mp4
Added listeners to handle job tags for pending and completed jobs, and updated controllers to support tag-based filtering of jobs. Added tests to verify the functionality of these new features.
Pending Tags:
StoreTagsForPendingJobfor theJobPushedevent; this appends tags to pending jobs.PendingJobsControllerto support searching based on pending tags.resources/js/screens/recentJobs/index.vueto facilitate tag searches.Completed Tags:
StoreTagsForCompletedJobfor theJobDeletedevent; pertinent completed jobs will now be tagged.ForgetJobInPendingTagsfor theJobDeletedevent; this removes the job from the pending tags.CompletedJobsControllerto allow searching for completed tags.resources/js/screens/recentJobs/index.vuefor tag-based searching.