Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Use 'default' connection as a default redis connection #765

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

binaryk
Copy link
Contributor

@binaryk binaryk commented Feb 16, 2020

This PR will fix the issue when the horizon is used as a dependency on another package. As an example, it was used by @freekmurze (https://github.com/freekmurze) in the https://mailcoach.app/ package, and the installation was stopped because of the value received in the Laravel\Horizon@use method was null (since I didn't have the config/horizon.php file locally).

@binaryk binaryk requested a review from taylorotwell February 16, 2020 18:34
@binaryk binaryk changed the title Use 'default' connection as config default Use 'default' connection as default redis connection Feb 16, 2020
@binaryk binaryk changed the title Use 'default' connection as default redis connection Use 'default' connection as a default redis connection Feb 16, 2020
@driesvints driesvints changed the title Use 'default' connection as a default redis connection [3.x] Use 'default' connection as a default redis connection Feb 17, 2020
@themsaid
Copy link
Member

What do you mean by stopped? if it's an error can you please share what you get?

@binaryk
Copy link
Contributor Author

binaryk commented Feb 17, 2020

@themsaid the error bellow is shown after installation horizon via third party package:
image
That's because in the Horizon.php we receive the connection as null if artisan horizon:install was not run before:
image

@taylorotwell taylorotwell merged commit 4544402 into laravel:3.0 Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants