Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Add separate screen for completed jobs #767

Merged
merged 5 commits into from
Feb 18, 2020

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Feb 17, 2020

This PR adds separate screens for Pending and Completed Jobs.

Trimming of pending and completed jobs is separate from trimming of recent jobs.

'recent' => 1440,
'completed' => 15,
'pending' => 60,
'recent_failed' => 10080,
'failed' => 10080,
'monitored' => 10080,

Recent jobs sorted set is only used to show the count of recent jobs in the dashboard screen.

Screen Shot 2020-02-17 at 7 44 11 PM


Screen Shot 2020-02-17 at 7 44 01 PM


Screen Shot 2020-02-17 at 7 44 06 PM

@themsaid themsaid changed the title Add separate screenf or completed jobs [4.x] Add separate screen for completed jobs Feb 18, 2020
@brunogaspar
Copy link

Thanks @themsaid , looks awesome!

@taylorotwell taylorotwell merged commit 0784517 into laravel:master Feb 18, 2020
@Cannonb4ll
Copy link
Contributor

So a few days later having worked with Horizon V4 I am not too sure if this was a right move, which I can elaborate.

It feels like I have to do way more clicks now. If I am on the "Pending" overview, the job gets processed and the list will be emptied. But how do I know if it failed or succeeded? It feels more cumbersome this way. The old overview would let you know it failed and was clickable right away.

A beter solution would be to have it like it was, with filter options.

Wonder what others think about this.

@driesvints
Copy link
Member

@Cannonb4ll the main reason for this was because it was very hard to do this in combination with how data was stored in Redis, especially for projects with lots and lots of jobs. In a queueing monitoring system like Horizon you're usually not watching the pending screen very often. We're going to leave it like this for now.

If you can come up with a proper solution to the problems that were caused by the previous screen and group everything you're free to send in a PR.

@Cannonb4ll
Copy link
Contributor

@driesvints Thank you for answering. I will give this some more thought and might prepare a concept PR. I think we can optimise a lot UX wise 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants