Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove job ID from title #768

Closed
wants to merge 66 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
8d57e1e
Update branch-alias
driesvints Feb 27, 2019
157c6ff
Suggest predis instead of requiring it
ThomHurks Feb 28, 2019
6462648
Fix the build, suggest phpredis.
ThomHurks Feb 28, 2019
7121e2a
Update composer.json
driesvints Feb 28, 2019
286186c
Update composer.json
taylorotwell Feb 28, 2019
2b6184b
Merge pull request #531 from ThomHurks/patch-2
taylorotwell Feb 28, 2019
327becd
Merge branch '3.0'
driesvints Mar 5, 2019
693471d
Merge branch '3.0'
driesvints Mar 8, 2019
e1e11be
Merge branch '3.0'
driesvints Mar 12, 2019
a33ae6a
Update changelog
driesvints Mar 12, 2019
551d677
Merge branch '3.0'
driesvints Mar 25, 2019
12f694b
Merge branch '3.0'
driesvints Mar 26, 2019
37d1a5c
Merge branch '3.0'
driesvints Apr 2, 2019
b38ff5b
Merge branch '3.0'
driesvints Apr 18, 2019
e731e84
Merge branch '3.0'
driesvints Apr 30, 2019
519ec92
Merge branch '3.0'
driesvints May 21, 2019
adf20c5
Merge branch '3.0'
driesvints Jul 11, 2019
3dcef58
Merge branch '3.0'
driesvints Jul 30, 2019
ebfa3b1
Drop support for 5.7
driesvints Jul 30, 2019
4c8b853
Merge branch '3.0'
driesvints Jul 30, 2019
3e8428f
Changed default Redis prefix
itorgov Aug 5, 2019
c0daa4f
Merge pull request #643 from ivantorgov/master
taylorotwell Aug 6, 2019
8f593ad
Merge branch '3.0'
driesvints Aug 6, 2019
94c8445
Update horizon.php
tomswinkels Aug 7, 2019
6b159b6
Merge pull request #646 from tomswinkels/patch-4
taylorotwell Aug 7, 2019
1290d65
Revert "[4.0] Change format"
taylorotwell Aug 8, 2019
7f6fbab
Merge pull request #648 from laravel/revert-646-patch-4
taylorotwell Aug 8, 2019
b1ebcc4
Merge branch '3.0'
driesvints Aug 20, 2019
a12468d
Drop PHP 7.1 support
driesvints Aug 22, 2019
4c1e36d
Merge branch '3.0'
driesvints Aug 23, 2019
8216c34
Drop Laravel 5.8 support
driesvints Aug 23, 2019
2eb9d6d
Bump Symfony dependencies
driesvints Aug 23, 2019
8312771
Update dev dependencies
driesvints Aug 23, 2019
17fcf93
Update CHANGELOG.md
driesvints Aug 23, 2019
93605c3
Merge branch '3.0'
driesvints Aug 27, 2019
e93833d
Merge branch '3.0'
driesvints Sep 10, 2019
d584709
Merge branch '3.0'
driesvints Sep 27, 2019
fd93642
Merge branch '3.0'
driesvints Oct 1, 2019
d9aaca1
Merge branch '3.0'
driesvints Oct 8, 2019
3cf374d
Rename asset command
dwightwatson Oct 27, 2019
a88f2b4
Merge pull request #696 from dwightwatson/publish-master
taylorotwell Oct 28, 2019
d02d637
Merge branch '3.0'
driesvints Oct 29, 2019
a749795
Merge branch '3.0'
driesvints Nov 1, 2019
14a3ac7
Added "Attempts" to jobs lists.
piotrgrabowskielastique Nov 6, 2019
8cb908c
Changed icon to a gear.
piotrgrabowskielastique Nov 7, 2019
0a20bc2
Merge branch '3.0'
driesvints Nov 14, 2019
1888e1a
Merge pull request #702 from piotrgrabowskielastique/master
taylorotwell Nov 14, 2019
5df9c79
Merge branch '3.0'
driesvints Nov 19, 2019
8bd6c63
Update branch alias
driesvints Nov 25, 2019
dfb81c6
Merge branch '3.0'
driesvints Nov 26, 2019
6747483
Update to Symfony 5
driesvints Nov 25, 2019
82d647c
Drop 6.x support
driesvints Nov 25, 2019
02f528e
Do not test on 6.0
driesvints Nov 26, 2019
57bad14
Replace trait
driesvints Nov 26, 2019
30f4133
Merge pull request #710 from laravel/symfony5
taylorotwell Nov 26, 2019
7d5d453
Merge branch '3.0'
driesvints Nov 26, 2019
8e9d147
Merge branch '3.0'
driesvints Dec 6, 2019
eb10c2d
Merge branch '3.0'
driesvints Dec 9, 2019
45ae07b
Merge branch '3.0'
driesvints Dec 30, 2019
0465918
Merge branch '3.0'
driesvints Jan 14, 2020
23c311b
Merge branch '3.0'
driesvints Jan 28, 2020
08a10ff
Merge branch '3.0'
driesvints Feb 4, 2020
f77a02a
Merge branch '3.0'
driesvints Feb 12, 2020
de0cf8e
Merge branch 'master' of https://github.com/laravel/horizon into 3.0
Cannonb4ll Feb 12, 2020
203a3c0
Merge branch '3.0' of https://github.com/laravel/horizon into 3.0
Cannonb4ll Feb 12, 2020
8e1fca9
Remove job ID from title
Cannonb4ll Feb 18, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,16 @@ services:
- redis-server

php:
- 7.1
- 7.2
- 7.3
- 7.4

env:
matrix:
- LARAVEL=5.7.*
- LARAVEL=5.8.*
- LARAVEL=^6.0
- LARAVEL=^7.0

matrix:
fast_finish: true
exclude:
- php: 7.1
env: LARAVEL=^6.0

before_install:
- phpenv config-rm xdebug.ini || true
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Release Notes

## [Unreleased](https://github.com/laravel/horizon/compare/v3.6.1...3.0)
## [Unreleased](https://github.com/laravel/horizon/compare/v3.6.1...master)

### Changed
- Dropped support for Laravel 5.8 ([8216c34](https://github.com/laravel/horizon/commit/8216c34736564998380f97252c117716020aee0a))
- Bumped minimum Symfony dependencies to 4.3 ([2eb9d6d](https://github.com/laravel/horizon/commit/2eb9d6d77acd5e8b42da0a8146c9e8d8105fbd8a))


## [v3.6.1 (2020-02-12)](https://github.com/laravel/horizon/compare/v3.6.0...v3.6.1)
Expand Down
24 changes: 14 additions & 10 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,27 @@
}
],
"require": {
"php": ">=7.1.0",
"php": "^7.2",
"ext-json": "*",
"ext-pcntl": "*",
"ext-posix": "*",
"cakephp/chronos": "^1.0",
"illuminate/contracts": "~5.7.0|~5.8.0|^6.0",
"illuminate/queue": "~5.7.0|~5.8.0|^6.0",
"illuminate/support": "~5.7.0|~5.8.0|^6.0",
"predis/predis": "^1.1",
"illuminate/contracts": "^7.0",
"illuminate/queue": "^7.0",
"illuminate/support": "^7.0",
"ramsey/uuid": "^3.5",
"symfony/process": "^4.2",
"symfony/debug": "^4.2"
"symfony/process": "^5.0",
"symfony/error-handler": "^5.0"
},
"require-dev": {
"mockery/mockery": "^1.0",
"orchestra/testbench": "^3.7|^4.0",
"phpunit/phpunit": "^7.0|^8.0"
"orchestra/testbench": "^5.0",
"phpunit/phpunit": "^8.0",
"predis/predis": "^1.1"
},
"suggest": {
"ext-redis": "Required to use the Redis PHP driver.",
"predis/predis": "Required when not using the Redis PHP driver (^1.1)."
},
"autoload": {
"psr-4": {
Expand All @@ -40,7 +44,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "3.0-dev"
"dev-master": "4.x-dev"
},
"laravel": {
"providers": [
Expand Down
7 changes: 6 additions & 1 deletion config/horizon.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

use Illuminate\Support\Str;

return [

/*
Expand Down Expand Up @@ -52,7 +54,10 @@
|
*/

'prefix' => env('HORIZON_PREFIX', 'horizon:'),
'prefix' => env(
'HORIZON_PREFIX',
Str::slug(env('APP_NAME', 'laravel'), '_').'_horizon:'
),

/*
|--------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion resources/js/screens/failedJobs/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
<br>

<small class="text-muted">
Queue: {{job.queue}} | Tags: {{ job.payload.tags && job.payload.tags.length ? job.payload.tags.join(', ') : '' }}
Queue: {{job.queue}} | Attempts: {{ job.payload.attempts }} | Tags: {{ job.payload.tags && job.payload.tags.length ? job.payload.tags.join(', ') : '' }}
</small>
</td>

Expand Down
2 changes: 0 additions & 2 deletions resources/js/screens/recentJobs/job-row.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
{{ jobBaseName(job.name) }}
</router-link>

{{ job.id }}

<small class="badge badge-secondary badge-sm"
v-tooltip:top="`Delayed for ${delayed}`"
v-if="delayed && (job.status == 'reserved' || job.status == 'pending')">
Expand Down
5 changes: 1 addition & 4 deletions src/Console/InstallCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,10 @@
namespace Laravel\Horizon\Console;

use Illuminate\Console\Command;
use Illuminate\Console\DetectsApplicationNamespace;
use Illuminate\Support\Str;

class InstallCommand extends Command
{
use DetectsApplicationNamespace;

/**
* The name and signature of the console command.
*
Expand Down Expand Up @@ -52,7 +49,7 @@ public function handle()
*/
protected function registerHorizonServiceProvider()
{
$namespace = Str::replaceLast('\\', '', $this->getAppNamespace());
$namespace = Str::replaceLast('\\', '', $this->laravel->getNamespace());

$appConfig = file_get_contents(config_path('app.php'));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@

use Illuminate\Console\Command;

class AssetsCommand extends Command
class PublishCommand extends Command
{
/**
* The name and signature of the console command.
*
* @var string
*/
protected $signature = 'horizon:assets';
protected $signature = 'horizon:publish';

/**
* The console command description.
*
* @var string
*/
protected $description = 'Re-publish the Horizon assets';
protected $description = 'Publish all of the Horizon resources';

/**
* Execute the console command.
Expand Down
8 changes: 4 additions & 4 deletions src/HorizonServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,13 @@ protected function registerCommands()
{
if ($this->app->runningInConsole()) {
$this->commands([
Console\InstallCommand::class,
Console\AssetsCommand::class,
Console\ContinueCommand::class,
Console\HorizonCommand::class,
Console\InstallCommand::class,
Console\ListCommand::class,
Console\PurgeCommand::class,
Console\PauseCommand::class,
Console\ContinueCommand::class,
Console\PublishCommand::class,
Console\PurgeCommand::class,
Console\StatusCommand::class,
Console\SupervisorCommand::class,
Console\SupervisorsCommand::class,
Expand Down
5 changes: 1 addition & 4 deletions src/MasterSupervisor.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
use Laravel\Horizon\Contracts\SupervisorRepository;
use Laravel\Horizon\Contracts\Terminable;
use Laravel\Horizon\Events\MasterSupervisorLooped;
use Symfony\Component\Debug\Exception\FatalThrowableError;
use Throwable;

class MasterSupervisor implements Pausable, Restartable, Terminable
Expand Down Expand Up @@ -246,10 +245,8 @@ public function loop()
$this->persist();

event(new MasterSupervisorLooped($this));
} catch (Exception $e) {
app(ExceptionHandler::class)->report($e);
} catch (Throwable $e) {
app(ExceptionHandler::class)->report(new FatalThrowableError($e));
app(ExceptionHandler::class)->report($e);
}
}

Expand Down
5 changes: 1 addition & 4 deletions src/Supervisor.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
use Laravel\Horizon\Contracts\SupervisorRepository;
use Laravel\Horizon\Contracts\Terminable;
use Laravel\Horizon\Events\SupervisorLooped;
use Symfony\Component\Debug\Exception\FatalThrowableError;
use Throwable;

class Supervisor implements Pausable, Restartable, Terminable
Expand Down Expand Up @@ -308,10 +307,8 @@ public function loop()
$this->persist();

event(new SupervisorLooped($this));
} catch (Exception $e) {
app(ExceptionHandler::class)->report($e);
} catch (Throwable $e) {
app(ExceptionHandler::class)->report(new FatalThrowableError($e));
app(ExceptionHandler::class)->report($e);
}
}

Expand Down