[4.x] Add metrics options and dark mode config #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
themsaid
approved these changes
Mar 18, 2020
|
This PR kind of broke how |
|
See #818 |
Closed
|
Hmm so the |
|
Hey @bert-w I've reverted that part in your PR. Please submit a new PR that works if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to have some more control over how the Metrics graphs were shown. It turns out only the last 24 snapshots are saved, so when creating a snapshot every 5 minutes that would result in (just) 2 hours of data. With the new
metrics.trim_snapshots.joboption, you are able to keep an x amount of snapshots, thus increasing the amount of points on the graph and showing you a bigger timespan.The following screenshots show the new metrics, with about 200 plot points (which is working on my machine without performance impact). Notice changed colors and the new date format.
In addition, I added the
'theme' => 'light'config, because I think this file should be the place to define such options (not in the service provider).Feedback is very welcome.