[4.x] Fix for job rows on monitoring tags screen #814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
Thanks everyone for your work on Horizon and all of the recent updates.
I noticed on the 4.1.0 release that the columns for Runtime and Status are not populated when monitoring tags. I've made sure that assets are being republished on deployment, but they still were not populating:
Fix
After digging in I found that the v-if in the new
job-row
component is using$route.params.type
when previously it relied on thetype
prop passed into the parent component. This PR changes the v-if to use the $parenttype
prop to fix this issue. It also changes the Runtime column to a dash (consistent with the status column) when a job isn't completed yet.I used $parent to retrieve the prop instead of passing into the new job-row component as it's already already being used on line 4: