Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix for job rows on monitoring tags screen #814

Merged
merged 1 commit into from
Mar 31, 2020
Merged

[4.x] Fix for job rows on monitoring tags screen #814

merged 1 commit into from
Mar 31, 2020

Conversation

joecampo
Copy link
Contributor

Hey there,

Thanks everyone for your work on Horizon and all of the recent updates.

I noticed on the 4.1.0 release that the columns for Runtime and Status are not populated when monitoring tags. I've made sure that assets are being republished on deployment, but they still were not populating:

image

Fix

After digging in I found that the v-if in the new job-row component is using $route.params.type when previously it relied on the type prop passed into the parent component. This PR changes the v-if to use the $parent type prop to fix this issue. It also changes the Runtime column to a dash (consistent with the status column) when a job isn't completed yet.

image

I used $parent to retrieve the prop instead of passing into the new job-row component as it's already already being used on line 4:

image

@themsaid themsaid merged commit e2bb711 into laravel:4.x Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants