-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] Chronos 2.0 #824
[4.x] Chronos 2.0 #824
Conversation
I guess it's fine to do this since the tests are passing. |
composer.json
Outdated
@@ -14,7 +14,7 @@ | |||
"ext-json": "*", | |||
"ext-pcntl": "*", | |||
"ext-posix": "*", | |||
"cakephp/chronos": "^1.0", | |||
"cakephp/chronos": "^1.0|^2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change this later on? I think the bump to just ^2.0
is perfectly fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case there are projects that use version 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those projects need to define the chronos dependency in their own composer.json if they depend on it directly. We're changing the dependency for Horizon here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I leave it like it was before
#823