Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Chronos 2.0 #824

Merged
merged 3 commits into from
Apr 13, 2020
Merged

[4.x] Chronos 2.0 #824

merged 3 commits into from
Apr 13, 2020

Conversation

sojeda
Copy link
Contributor

@sojeda sojeda commented Apr 13, 2020

@driesvints
Copy link
Member

I guess it's fine to do this since the tests are passing.

driesvints
driesvints previously approved these changes Apr 13, 2020
composer.json Outdated
@@ -14,7 +14,7 @@
"ext-json": "*",
"ext-pcntl": "*",
"ext-posix": "*",
"cakephp/chronos": "^1.0",
"cakephp/chronos": "^1.0|^2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this later on? I think the bump to just ^2.0 is perfectly fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case there are projects that use version 1

Copy link
Member

@driesvints driesvints Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those projects need to define the chronos dependency in their own composer.json if they depend on it directly. We're changing the dependency for Horizon here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I leave it like it was before

@driesvints driesvints dismissed their stale review April 13, 2020 13:17

Author made new changes

@sojeda sojeda requested a review from driesvints April 13, 2020 13:28
@taylorotwell taylorotwell merged commit 21dd804 into laravel:4.x Apr 13, 2020
@sojeda sojeda deleted the feature/upgradeChronos branch April 13, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants