[5.x] Fix misleading memory limit config #908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
memory_limit
Horizon configuration is misleading. It reads that it's the max memory for the queue workers, when instead, it is the memory limit for the master supervisor (default 64 MB). The memory limit for the workers percolates down from the supervisor memory limit (default 128 MB).This PR fixes the wording and also makes it clear that the supervisor memory option is the one for the queue workers. This is a non-breaking change, as the config defaults are the same (64 MB for master supervisor and 128 MB for supervisors + queue workers).
Edit: On digging further, I realised this issue has been lingering from quite some time now: #712