Get fresh user instance on two factor authentication tests #1281
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my installation, these tests fail because the user doesn't have the `two_factor_confirmed_at` attribute: ``` The attribute [two_factor_confirmed_at] either does not exist or was not retrieved for model [App\Models\User]. (View: /var/www/html/vendor/livewire/livewire/src/views/mount-component.blade.php) ``` I believe this is because the factory doesn't specify the attribute. I considered updating the factory to include it (set to `null`), but then I thought it might be a little messy because there should be a check to see if the feature's enabled. This solution, however, requires everyone to remember to get a fresh user instance, when needed, without it being clear as to why. So...let me know if I should try a different approach...
|
I assume this is because you're using some of Eloquent's strict features? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my installation, these tests fail because the user doesn't have the
two_factor_confirmed_atattribute:I believe this is because the factory doesn't specify the attribute.
I considered updating the factory to include it (set to
null), but then I thought it might be a little messy because there should be a check to see if the feature's enabled.This solution, however, requires everyone to remember to get a fresh user instance, when needed, without it being clear as to why.
So...let me know if I should try a different approach...