Use getAuthIdentifier instead of getKey for compatibility with other Laravel auth providers #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides the ability to use other authentication providers with Jetstream (Inertia), since this method is required to be implemented via the Authenticatable contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This PR provides further support for other authentication providers in Jetstream.
Reason:
Since the
getKey()method is not apart of theAuthenticatablecontract, anyone attempting to use the Inertia stack in Jetstream with another authentication provider cannot do so if the authenticatable user does not implement thegetKey()method.Details:
It would be great to use the
getAuthIdentifier()method instead ofgetKey()since the former is implemented in the Authenticatable contract when using other authentication providers in Jetstream.Breaking Changes:
There are no breaking changes in this PR. The
getAuthIdentifier()method uses theiddatabase column by default on the includedApp\Models\Usermodel. Anyone who has adjusted or modified their primary user key will also be compatible with this change, due to theIlluminate\Auth\Authenticatabletrait retrieving the key name dynamically from the model's$primaryKeyproperty.If there are any questions or concerns please let me know! 👍 ❤️