Ability to set perPageOptions for Lenses

[trovster]

I have a lens which I want to limit the per-page options for. However, I am unable to do this. I would have hope the perPageOptions() method from the resource could be added to the lens and this used as an override. This doesn't work.

The LensRequest uses the resources perPageOptions() options.

// LensRequest.php
public function perPage()
{
    $resource = $this->resource();

    $perPageOptions = $resource::perPageOptions();

    if (empty($perPageOptions)) {
        $perPageOptions = [$resource::newModel()->getPerPage()];
    }

    return (int) in_array($this->perPage, $perPageOptions) ? $this->perPage : $perPageOptions[0];
}

The ResourceIndexRequest has a check for relationship and uses the $perPageViaRelationship options. A similar approach could be used for LensRequests.

// ResourceIndexRequest.php
public function perPage()
{
    $resource = $this->resource();

    if ($this->viaRelationship()) {
        return (int) $resource::$perPageViaRelationship;
    }

    $perPageOptions = $resource::perPageOptions();

    if (empty($perPageOptions)) {
        $perPageOptions = [$resource::newModel()->getPerPage()];
    }

    return (int) in_array($this->perPage, $perPageOptions) ? $this->perPage : $perPageOptions[0];
}

[crynobone]

Will be available in 5.2.0

[crynobone]

Released