Fix swoole host only configurable via --host parameter + incorrect de…

…fault port (#762) * remove default values for --host * fix incorrect default port
laravel · Oct 18, 2023 · 6dbb1d8 · 6dbb1d8
1 parent fc4cb9a
commit 6dbb1d8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/bin/createSwooleServer.php b/bin/createSwooleServer.php
@@ -9,7 +9,7 @@
 
     $server = new Swoole\Http\Server(
         $host,
-        $serverState['port'] ?? 8080,
+        $serverState['port'] ?? 8000,
         $config['swoole']['mode'] ?? SWOOLE_PROCESS,
         ($config['swoole']['ssl'] ?? false)
             ? $sock | SWOOLE_SSL

diff --git a/src/Commands/StartCommand.php b/src/Commands/StartCommand.php
@@ -15,7 +15,7 @@ class StartCommand extends Command implements SignalableCommandInterface
      */
     public $signature = 'octane:start
                     {--server= : The server that should be used to serve the application}
-                    {--host=127.0.0.1 : The IP address the server should bind to}
+                    {--host= : The IP address the server should bind to}
                     {--port= : The port the server should be available on [default: "8000"]}
                     {--rpc-host= : The RPC IP address the server should bind to}
                     {--rpc-port= : The RPC port the server should be available on}

diff --git a/src/Commands/StartRoadRunnerCommand.php b/src/Commands/StartRoadRunnerCommand.php
@@ -22,7 +22,7 @@ class StartRoadRunnerCommand extends Command implements SignalableCommandInterfa
      * @var string
      */
     public $signature = 'octane:roadrunner
-                    {--host=127.0.0.1 : The IP address the server should bind to}
+                    {--host= : The IP address the server should bind to}
                     {--port= : The port the server should be available on}
                     {--rpc-host= : The RPC IP address the server should bind to}
                     {--rpc-port= : The RPC port the server should be available on}

diff --git a/src/Commands/StartSwooleCommand.php b/src/Commands/StartSwooleCommand.php
@@ -20,7 +20,7 @@ class StartSwooleCommand extends Command implements SignalableCommandInterface
      * @var string
      */
     public $signature = 'octane:swoole
-                    {--host=127.0.0.1 : The IP address the server should bind to}
+                    {--host= : The IP address the server should bind to}
                     {--port= : The port the server should be available on}
                     {--workers=auto : The number of workers that should be available to handle requests}
                     {--task-workers=auto : The number of task workers that should be available to handle tasks}