Process->getIncrementalOutput() does not flush output buffer

[tezhm]

• Octane Version: 1.0.18
• Laravel Version: 8.70.2
• PHP Version: 8.0.13
• Server & Version: Swoole / RoadRunner 2.5.6
• Database Driver & Version:

Description:

StartRoadRunnerCommand->writeServerOutput() queries the worker output via Process->getIncrementalOutput() which internally buffers the worker process output. This buffer is not flushed and thus keeps growing indefinitely.

I have worked around this by calling Process->clearOutput() and Process->clearErrorOutput() after each call to StartRoadRunnerCommand->writeServerOutput().

Steps To Reproduce:

Start octane server for roadrunner binary and log to stderr from workers.

[nunomaduro]

@tezhm What exactly makes you think that "This buffer is not flushed and thus keeps growing indefinitely."? What have you used to conclude this?

[tezhm]

Process stores output logs to php://temp. This buffer temporarily stores logs to file after output reaches a certain size. The `getIncrementalOutput()` iterates over output rather than flushing it. Reason for this is so all output can be queried later using `getOutput()`. Thus, if output is never flushed the temporary file will grow indefinitely.

…

On Sat, 27 Nov 2021, 3:51 am Nuno Maduro, ***@***.***> wrote: @tezhm <https://github.com/tezhm> What exactly makes you think that "This buffer is not flushed and thus keeps growing indefinitely."? What have you used to conclude this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVGACFHN37WZHHZDY7QSV3UN7CKLANCNFSM5IZ3B4WA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.