Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix byte conversion #465

Merged
merged 2 commits into from
Jan 25, 2022
Merged

[1.x] Fix byte conversion #465

merged 2 commits into from
Jan 25, 2022

Conversation

apih
Copy link
Contributor

@apih apih commented Jan 25, 2022

This pull request fixes the conversion of memory value, from bytes to megabytes.

@driesvints driesvints marked this pull request as draft January 25, 2022 14:08
@driesvints
Copy link
Member

This seems to break the test suite. Please fix the tests first and mark as ready for review when done. Thanks

@apih apih marked this pull request as ready for review January 25, 2022 14:33
@taylorotwell taylorotwell merged commit 1e06328 into laravel:1.x Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants