Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Adds support for Swoole 5 #560

Merged
merged 2 commits into from
Aug 2, 2022
Merged

[1.x] Adds support for Swoole 5 #560

merged 2 commits into from
Aug 2, 2022

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Aug 2, 2022

This pull request adds support for Swoole 5.

Here is the list of breaking changes, between Swoole 4 and 5: https://github.com/swoole/swoole-src/blob/master/CHANGELOG.md#2022-07-22-v500. Yet, the only change affecting Octane is the removal of Server::tick.

Fixes #559.

@nunomaduro nunomaduro requested a review from taylorotwell August 2, 2022 15:32
@nunomaduro nunomaduro marked this pull request as ready for review August 2, 2022 15:33
@taylorotwell taylorotwell merged commit 93dfdb5 into 1.x Aug 2, 2022
@taylorotwell taylorotwell deleted the feat/swoole5 branch August 2, 2022 15:44
@Spice-King
Copy link

For those looking at this down the road, they moved the change log and broke the link to it. Here is a permalink to it so that people that are like me and wanting to see if Swoole 5 might break or add something interesting because dependabot mentioned this PR/commit.

@flexchar
Copy link

flexchar commented Sep 3, 2022

CHANGELOG has been moved to /docs folder. New link https://github.com/swoole/swoole-src/blob/master/docs/CHANGELOG.md#2022-07-22-v500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught Error: Call to undefined method Swoole\Http\Server::tick
4 participants