[Bug][Swoole] Disable unintentional swoole header formatting by config value #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this Pull Request i want to fix a bug where Swoole is formatting headers names unintentionally.
Swoole and Open Swoole are formatting headers by default.
https://openswoole.com/docs/modules/swoole-http-response-header
It seems odd that octane calles ResponseHeaderBag's allPreserveCase presumably to preserve the casing.
octane/src/Swoole/SwooleClient.php
Line 156 in d962806
But few lines later swoole will format it.
octane/src/Swoole/SwooleClient.php
Line 164 in d962806
The swoole formatting should be adjustable by config, so it could be behave like Laravel and Symfony by default.
This change is backwards compatible, because the default is still "true".
on-behalf-of: @e-solutions-GmbH info@esolutions.de